Skip to content

Added customization options for configuration to allow more styling #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added customization options for configuration to allow more styling #43

wants to merge 2 commits into from

Conversation

@ValentinDenis
Copy link

@ValentinDenis ValentinDenis commented Oct 16, 2019

I added a few customization elements that I needed for my project. These are:

  • Allowing to add borders (black and not customizable for now) to cells and headers
  • Allowing to change header background color (I added a new backgroundView to the headerFooter xib since you can't change backgroundColor of reusableViews, by default it's UIColor.clear)
  • Allowing to change text alignement for Header/Footer and data Cells (by default .natural to keep handling RTL languages)

@pavankataria
Copy link
Owner

pavankataria commented Oct 22, 2019

Hey, I look forward to checking this out during the weekend! Great work here.

Have you considered adding an example which showcases this work?
Consider adding it in the menu view controller to showcase this work in the mean time.

@ValentinDenis
Copy link
Author

ValentinDenis commented Oct 25, 2019

I added 3 MenuItems as examples, I hope this will do :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ValentinDenis @pavankataria